Include delete and actual request timestamp #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjoshi30
reviewed
Sep 4, 2024
aimon/decorators/analyze.py
Outdated
| @@ -192,6 +192,7 @@ def _run_production_analysis(self, func, args, kwargs): | |||
| "context_docs": _context, | |||
| "user_query": result_dict["user_query"] if 'user_query' in result_dict else "No User Query Specified", | |||
| "prompt": result_dict['prompt'] if 'prompt' in result_dict else "No Prompt Specified" | |||
pjoshi30
reviewed
Sep 4, 2024
| @@ -9,3 +9,5 @@ | |||
|
|
|||
| class AnalyzeCreateResponse(BaseModel): | |||
| message: Optional[str] = None | |||
|
|
|||
| status: Optional[str] = None | |||
There was a problem hiding this comment.
need this to be of type int not Optional as well
pjoshi30
reviewed
Sep 4, 2024
aimon/decorators/analyze.py
Outdated
| @@ -191,7 +191,8 @@ def _run_production_analysis(self, func, args, kwargs): | |||
| "output": result_dict['generated_text'], | |||
| "context_docs": _context, | |||
| "user_query": result_dict["user_query"] if 'user_query' in result_dict else "No User Query Specified", | |||
| "prompt": result_dict['prompt'] if 'prompt' in result_dict else "No Prompt Specified" | |||
| "prompt": result_dict['prompt'] if 'prompt' in result_dict else "No Prompt Specified", | |||
| "actual_request_timestamp": result_dict['actual_request_timestamp'] if 'actual_request_timestamp' in result_dict else "" | |||
There was a problem hiding this comment.
in the SDK backend, is the actual_request_timestamp a required field? If not, then lets add this to the payload only if it exists in the result_dict instead of setting it to empty string:
if 'actual_request_timestamp' in result_dict:
payload["actual_request_timestamp"] = result_dict['actual_request_timestamp']
pjoshi30
reviewed
Sep 4, 2024
| @@ -9,3 +9,5 @@ | |||
|
|
|||
| class AnalyzeCreateResponse(BaseModel): | |||
| message: Optional[str] = None | |||
|
|
|||
| status: str | |||
There was a problem hiding this comment.
@ramoncelestino why is this still a string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.