Fix: prevent IndexError in list_corrupted_runs for empty prefix#3400
Open
Regg819 wants to merge 1 commit intoaimhubio:mainfrom
Open
Fix: prevent IndexError in list_corrupted_runs for empty prefix#3400Regg819 wants to merge 1 commit intoaimhubio:mainfrom
Regg819 wants to merge 1 commit intoaimhubio:mainfrom
Conversation
When decode_path() returns an empty list for an empty byte string prefix, accessing [-1] causes IndexError. This fix adds a check to return None for empty paths and filters them out, preventing the crash. Fixes issue aimhubio#3390
|
|
Author
|
Hi team! Just checking in on this PR. Happy to address any feedback or make adjustments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
list_corrupted_runs()when processing corrupted databases with empty prefixes.Bug
IndexError: list index out of rangedecode_path(prefix)returns empty list[]when prefix isb"", and accessing[-1]on empty list crashesFix
get_run_hash_from_prefixNonefor empty paths and filter them outTesting
This fix handles the edge case where corrupted_dbs contains entries with empty byte string prefixes.