Skip to content

Aim crashes after trying to add duplicate tag to run #3277

Open
@feldlime

Description

@feldlime

🐛 Bug

When trying to add the same tag to a run, it fails as expected (but the error is not clear at all).
After this, it's impossible to create another run, it fails with SQLite error.

To reproduce

Part 1

run = aim.Run(repo=REPO)
run.add_tag("some_tag")
run.add_tag("some_tag")

This fails with TypeError: __init__() missing 2 required positional arguments: 'params' and 'orig'

Part 2

After this basic run creation

run = aim.Run(repo=REPO)

fails with error

PendingRollbackError: This Session's transaction has been rolled back due to a previous exception during flush. To begin a new transaction with this Session, first issue Session.rollback(). Original exception was: (sqlite3.IntegrityError) UNIQUE constraint failed: run_tag.run_id, run_tag.tag_id
[SQL: INSERT INTO run_tag (run_id, tag_id) VALUES (?, ?)]
[parameters: (30, 2)]
(Background on this error at: https://sqlalche.me/e/20/gkpj)

Expected behavior

In Part 1 expected a clear error like the tag is already present in the run and no error after this.

Environment

  • Aim Version: 3.24.0
  • Python version: 3.9
  • pip version --
  • OS (e.g., Linux): Linux
  • Any other relevant information: Running on the remote server

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is neededtype / bugIssue type: something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions