Upgrade to .net 8.0

aimenux · Mar 6, 2024 · 098ff53 · 098ff53
1 parent d1ef848
commit 098ff53
Show file tree

Hide file tree

Showing 12 changed files with 26 additions and 25 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,11 +15,11 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Setup .NET
-      uses: actions/setup-dotnet@v3
+      uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 7.0.x
+        dotnet-version: 8.0.x
     - name: Restore dependencies
       run: dotnet restore      
     - name: Build

diff --git a/README.md b/README.md
@@ -8,4 +8,4 @@ Using pipeline behaviors to implement cross-cutting concerns
 In this repo, i m using [pipeline behaviors](https://github.com/jbogard/MediatR/wiki/Behaviors) to implement cross-cutting concerns (validation, logging, etc).
 
 >
-**`Tools`** : net 7.0, web api, mediatr, unit-testing, integration-testing
+**`Tools`** : net 8.0, web api, mediatr, unit-testing, integration-testing
diff --git a/src/Application/Filters/ApiExceptionFilter.cs b/src/Application/Filters/ApiExceptionFilter.cs
@@ -64,7 +64,7 @@ private static void HandleUnhandledException(ExceptionContext context)
         var exception = context.Exception;
         var details = new ProblemDetails
         {
-            Type = "https://datatracker.ietf.org/doc/html/rfc7231#section-6.6.1",
+            Type = "https://tools.ietf.org/html/rfc7231#section-6.6.1",
             Title = "Internal Server Error.",
             Detail = exception.Message
         };

diff --git a/src/Application/UseCases/GetWeatherByCity/GetWeatherByCityQuery.cs b/src/Application/UseCases/GetWeatherByCity/GetWeatherByCityQuery.cs
@@ -2,4 +2,4 @@
 
 namespace PipelineBehaviorsDemo.Application.UseCases.GetWeatherByCity;
 
-public sealed record GetWeatherByCityQuery(string city) : IRequest<GetWeatherByCityQueryResponse>;
+public sealed record GetWeatherByCityQuery(string City) : IRequest<GetWeatherByCityQueryResponse>;
diff --git a/src/Application/UseCases/GetWeatherByCity/GetWeatherByCityQueryHandler.cs b/src/Application/UseCases/GetWeatherByCity/GetWeatherByCityQueryHandler.cs
@@ -17,7 +17,7 @@ public GetWeatherByCityQueryHandler(IWeatherProvider weatherProvider)
 
     public async Task<GetWeatherByCityQueryResponse> Handle(GetWeatherByCityQuery request, CancellationToken cancellationToken)
     {
-        var city = new City(request.city.ToUpper());
+        var city = new City(request.City.ToUpper());
         if (!CityBusinessRules.IsSupportedCity(city))
         {
             throw NotFoundException.CityIsNotFound(city);

diff --git a/src/Application/UseCases/GetWeatherByCity/GetWeatherByCityQueryValidator.cs b/src/Application/UseCases/GetWeatherByCity/GetWeatherByCityQueryValidator.cs
@@ -6,7 +6,7 @@ public class GetWeatherByCityQueryValidator : AbstractValidator<GetWeatherByCity
 {
     public GetWeatherByCityQueryValidator()
     {
-        RuleFor(x => x.city)
+        RuleFor(x => x.City)
             .NotEmpty()
             .MinimumLength(3)
             .MaximumLength(100)

diff --git a/src/PipelineBehaviorsDemo.csproj b/src/PipelineBehaviorsDemo.csproj
@@ -7,11 +7,11 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="FluentValidation" Version="11.8.0" />
-    <PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="11.8.0" />
-    <PackageReference Include="MediatR" Version="12.1.1" />
+    <PackageReference Include="FluentValidation" Version="11.9.0" />
+    <PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="11.9.0" />
+    <PackageReference Include="MediatR" Version="12.2.0" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Versioning" Version="5.1.0" />
-    <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.13" />
+    <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.16" />
     <PackageReference Include="Swashbuckle.AspNetCore" Version="6.5.0" />
     <PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="6.5.0" />
   </ItemGroup>

diff --git a/src/Presentation/Controllers/V1/GetWeatherByCity/GetWeatherByCityApiResponse.cs b/src/Presentation/Controllers/V1/GetWeatherByCity/GetWeatherByCityApiResponse.cs
@@ -1,6 +1,6 @@
 namespace PipelineBehaviorsDemo.Presentation.Controllers.V1.GetWeatherByCity;
 
-public class GetWeatherByCityApiResponse
+public sealed record GetWeatherByCityApiResponse
 {
     public string City { get; init; } = default!;
     public DateOnly Date { get; init; }

diff --git a/src/Presentation/DependencyInjection.cs b/src/Presentation/DependencyInjection.cs
@@ -20,13 +20,14 @@ public static IServiceCollection AddPresentation(this IServiceCollection service
 
     private static IServiceCollection AddApiVersioning(this IServiceCollection services)
     {
-        const string name = "x-api-version";
+        const string name = "X-Api-Version";
         services.AddApiVersioning(config =>
         {
             config.ReportApiVersions = true;
             config.AssumeDefaultVersionWhenUnspecified = true;
             config.DefaultApiVersion = new ApiVersion(1, 0);
-            config.ApiVersionReader = ApiVersionReader.Combine(new UrlSegmentApiVersionReader(),
+            config.ApiVersionReader = ApiVersionReader.Combine(
+                new UrlSegmentApiVersionReader(),
                 new HeaderApiVersionReader(name),
                 new MediaTypeApiVersionReader(name));
         });

diff --git a/test/IntegrationTests/WebApiTests.cs → test/IntegrationTests/IntegrationTests.cs b/test/IntegrationTests/WebApiTests.cs → test/IntegrationTests/IntegrationTests.cs
@@ -3,15 +3,15 @@
 
 namespace PipelineBehaviorsDemo.Tests.IntegrationTests;
 
-public class WebApiTests
+public class IntegrationTests
 {
     [Theory]
     [InlineData("api/v1/weathers/rome")]
     [InlineData("api/v1/weathers/carthage")]
     public async Task Should_Get_Weather_By_City_Returns_Ok(string route)
     {
         // arrange
-        var fixture = new WebApiTestFixture();
+        var fixture = new IntegrationWebApplicationFactory();
         var client = fixture.CreateClient();
 
         // act
@@ -29,7 +29,7 @@ public async Task Should_Get_Weather_By_City_Returns_Ok(string route)
     public async Task Should_Get_Weather_By_City_Returns_BadRequest(string route)
     {
         // arrange
-        var fixture = new WebApiTestFixture();
+        var fixture = new IntegrationWebApplicationFactory();
         var client = fixture.CreateClient();
 
         // act
@@ -47,7 +47,7 @@ public async Task Should_Get_Weather_By_City_Returns_BadRequest(string route)
     public async Task Should_Get_Weather_By_City_Returns_NotFound(string route)
     {
         // arrange
-        var fixture = new WebApiTestFixture();
+        var fixture = new IntegrationWebApplicationFactory();
         var client = fixture.CreateClient();
 
         // act

diff --git a/test/IntegrationTests/WebApiTestFixture.cs → ...Tests/IntegrationWebApplicationFactory.cs b/test/IntegrationTests/WebApiTestFixture.cs → ...Tests/IntegrationWebApplicationFactory.cs
@@ -4,7 +4,7 @@
 
 namespace PipelineBehaviorsDemo.Tests.IntegrationTests;
 
-internal class WebApiTestFixture : WebApplicationFactory<Program>
+internal class IntegrationWebApplicationFactory : WebApplicationFactory<Program>
 {
     protected override void ConfigureWebHost(IWebHostBuilder builder)
     {

diff --git a/test/PipelineBehaviorsDemo.Tests.csproj b/test/PipelineBehaviorsDemo.Tests.csproj
@@ -10,14 +10,14 @@
 
   <ItemGroup>
     <PackageReference Include="FluentAssertions" Version="6.12.0" />
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.13" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
-    <PackageReference Include="xunit" Version="2.6.1" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.16" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+    <PackageReference Include="xunit" Version="2.7.0" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.7">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="6.0.0">
+    <PackageReference Include="coverlet.collector" Version="6.0.1">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>