Skip to content

Commit

Permalink
Improve ThreeMigrationGuide.md (facebookarchive#1878)
Browse files Browse the repository at this point in the history
* Add `ASImageCacherCompletion` breaking API change.

* Remove unnecessary trailing pounds.
  • Loading branch information
rogerluan authored Jun 29, 2020
1 parent 6a3a247 commit 8e91008
Showing 1 changed file with 22 additions and 2 deletions.
24 changes: 22 additions & 2 deletions ThreeMigrationGuide.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
### Texture 3.0 Migration Guide ###
## Texture 3.0 Migration Guide

Got a tip for upgrading? Please open a PR to this document!
Got a tip for upgrading? Please open a PR to this document!


### Breaking API Changes

`ASImageCacherCompletion` typedef has a new parameter: `ASImageCacheType cacheType`. Example:


```swift
ASPINRemoteImageDownloader.shared().cachedImage(with: url, callbackQueue: .main) { result in
}
```

Becomes

```swift
ASPINRemoteImageDownloader.shared().cachedImage(with: url, callbackQueue: .main) { result, cacheType in
}
```

0 comments on commit 8e91008

Please sign in to comment.