Decision List Learner implemented #998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this PR? |
antmarakis
reviewed
Mar 3, 2019
There was a problem hiding this comment.
Overall it seems like a good PR, but you should wait for @norvig to respond, since it is too substantial for me to merge.
learning.py
Outdated
| def DecisionListLearner(dataset): | ||
| """[Figure 18.11]""" | ||
| def add(self, attr, value): | ||
| """add new attribute and value to the test""" |
There was a problem hiding this comment.
Minor edit, but can you please capitalize the start of your sentences, for consistency's case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The implementation of DecisionListLearner was incomplete (discussed in #948). I've implemented the algorithm, written tests and updated the corresponding notebook.
Here's what I've done:
DLTest class represents tests in the decision list. A
DLTesthasattr_valuesto hold attributes and corresponding values to test them against. It has some member functions like callingmatcheswith an example as input checks whether the example passes the test or not, callingmatched_examplesorunmached_exampleswith inputs as a list of examples returns a subset of examples which pass and don't pass the test respectively.create_DLTests creates a list of all possible
DLTests which are used in creating Decision List. (Decision List Learner repeatedly loops on these tests so as to find a test that agrees exactly with some subset of the training set.) It takes as inputattribute_countwhich is the maximum number of attributes to consider while creating a test. As of nowattribute_count=1 is supported.DecisionListLearner is the implementation of the of Decision list learner as mentioned in the book. Member function
decision_list_learningis the python implementation of the pseudocodeI've added test for
DecisionListLearnerhere.I've updated the learning.ipynb to include
DecisionListLearner. I've also added an image in its description.The code is well documented, let me know if you need any clarifications regarding the code.