Skip to content

Implementing Vectorization #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

glitch401
Copy link

Vectorization can reduce the run time by replacing large loop operations significantly !

For proof of Run time improvements
image

Copy link
Contributor

@ad71 ad71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@glitch401
Copy link
Author

glitch401 commented Jan 12, 2019

the performance of runtime significantly increases using vectorization!
It now handles matrices of different orders, naively.
I am also looking into implementation od unequal matrix orders.

Vectorization can reduce the runtime by  replacing large loop operations significantly !
Vectorization can reduce the runtime by  replacing large loop operations significantly !
@antmarakis
Copy link
Collaborator

Even though this is quite an improvement, I don't know if this is needed. Is there a place in the repository that would benefit from this change? Some function that takes too long because of the current implementation, perhaps?

I would prefer to keep the code as "bare-bones" as possible, without the use of external functionality, unless absolutely necessary.

@glitch401
Copy link
Author

I would totally agree with your perspective of keeping the code to the bare bones, Sir. But I think, the dot product is used multiple times throughout the repo, so just was a suggestion to improve the runtime, its only an if statement, with 4 lines of code added in total. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants