-
Notifications
You must be signed in to change notification settings - Fork 803
AIMA4e Search #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIMA4e Search #431
Conversation
@norvig Please have a look. |
HashSet<S> reached = new HashSet<>(); | ||
// solution ← failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this style, where the comments duplicate the code. I think it is good to have the pseudocode in a block comment, but then the Java implementation should stand by itself. Any Java programmer knows what reached = new HashSet<>();
means; we don't need to duplicate that in the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@norvig
Sure, sir, I will have these duplicate comments removed. I added them just because of the older versions. I will have them removed.
@norvig
|
@norvig |
Looks good! |
This PR adds the generic search algorithm to the AIMA4e branch. For testing, the generic search is extended as bfs and dfs. It is then applied to the Romania problem.