Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature of seekpath_structure_analysis of aiida-quantumespresso has changed #3

Open
sphuber opened this issue Apr 11, 2020 · 2 comments
Open

Signature of seekpath_structure_analysis of aiida-quantumespresso has changed #3

sphuber opened this issue Apr 11, 2020 · 2 comments

Comments

@sphuber
Copy link

sphuber commented Apr 11, 2020

I noticed that in the Wannier90BandsWorkChain you call the seekpath_structure_analysis function from aiida-quantumespresso, but in this commit I have updated the signature. Instead of a single Dict node for the parameters, it now expects individual nodes as keyword arguments.
@sphuber sphuber mentioned this issue Apr 11, 2020
Closed
hongyi-zhao added a commit to hongyi-zhao/aiida-wannier90-workflows that referenced this issue Apr 16, 2020
@hongyi-zhao
See here aiidateam#3
c00dd54 
and
aiidateam/aiida-quantumespresso@ec24908

`seekpath_structure_analysis`: expand parameter input into keywords

So, adjust the call method for the seekpath_structure_analysis function accordingly.
@hongyi-zhao hongyi-zhao mentioned this issue Apr 16, 2020
Merged
@hongyi-zhao
Copy link
Contributor

hongyi-zhao commented Apr 16, 2020 •
edited
Loading

@sphuber There is no one till now try to fix the problem. I committed a PR, could you please let the aiidateam check and merge it?

Regards

@qiaojunfeng
Copy link
Collaborator

Thank you @sphuber and @hongyi-zhao !
Sorry about my late reply, I wasn't notified cause the GitHub notification was set to Not Watching for me, funny. I explicitly set Watching for this repo so this won't happen again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sphuber @hongyi-zhao @qiaojunfeng