Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for running through basics- verdi cli section #236

Merged
merged 5 commits into from
Jul 1, 2020
Merged

fixes for running through basics- verdi cli section #236

merged 5 commits into from
Jul 1, 2020

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jun 30, 2020 •
edited
Loading

fixes #146
fixes #184
fixes #240

@ltalirz
Copy link
Member Author

ltalirz commented Jun 30, 2020 •
edited
Loading

@giovannipizzi @chrisjsewell @sphuber
I have tested the 'Basics' section and this PR includes a couple of fixes.

Issues to be resolved elsewhere:
#241
#239
#238 <= I could address this issue in this PR as well but I'm not sure what the original intention is, perhaps @sphuber will know
#237

sphuber
sphuber reviewed Jul 1, 2020
View reviewed changes
docs/pages/2020_Intro_Week/sections/basics.rst
output_kpoints 1455 KpointsData
output_parameters 789 Dict
output_structure 788 StructureData
output_trajectory_array 790 ArrayData
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this is output_trajectory_array? I think This should be output_trajectory 790 TrajectoryData

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply copy-pasted the output of verdi process show ce81c420-7751-48f6-af8e-eb7c6a30cec from the tutorial VM - feel free to re-check on your VM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so that is a node that is imported from the perovskites archive. This was incorrectly migrated. But it is not a big deal, so let's leave it

docs/pages/2020_Intro_Week/sections/basics.rst Outdated Show resolved Hide resolved
@ltalirz @sphuber
Update docs/pages/2020_Intro_Week/sections/basics.rst
bc335fc 
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
@ltalirz
Copy link
Member Author

ltalirz commented Jul 1, 2020

Thanks for the review @sphuber !
I'm merging this now; if your comment needs further investigation, we can fix it in a separate PR

@ltalirz ltalirz merged commit 25e8df3 into aiidateam:2020-intro-week Jul 1, 2020
@csadorf csadorf mentioned this pull request Jul 1, 2020
Closed
@mbercx mbercx mentioned this pull request Jul 6, 2020
Merged
@ltalirz ltalirz mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltalirz @sphuber