Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Improve repo format #9

Merged
merged 11 commits into from
Jun 2, 2021
Merged

🔧 MAINTAIN: Improve repo format #9

merged 11 commits into from
Jun 2, 2021

Conversation

chrisjsewell
Copy link
Member

  • add build-system
  • update pre-commit
  • move from yapf -> black
  • update manifest
  • add isort
  • add codecov
  • add testing for multiple python versions
  • add mypy configuration
  • add tox configuration

- add build-system
- update pre-commit
- move from yapf -> black
- update manifest
- add isort
- add codecov
- add testing for multiple python versions
- add mypy configuration
- add tox configuration
@chrisjsewell
Copy link
Member Author

few minor mypy failures that I'll fix later

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chrisjsewell ! Looks fine to me, just some comments/questions

I hope @NinadBhat's work so far has not overlapped too much with this (apologies if it did).
In any case, please see this as encouragement to make PRs early ;-)

.pre-commit-config.yaml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
mypy.ini Show resolved Hide resolved
@chrisjsewell chrisjsewell requested a review from ltalirz June 2, 2021 06:14
@chrisjsewell
Copy link
Member Author

I hope @NinadBhat's work so far has not overlapped too much with this (apologies if it did).

yep, and happy to explain any of the additions, and also how to use tox which I highly suggest 😄 (and pre-commit insall)

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Jun 2, 2021

Also FYI, this is my .vscode/settings.json:

{
    "editor.rulers": [88],
    "files.exclude": {
        "**/.git": true,
        "**/.svn": true,
        "**/.hg": true,
        "**/CVS": true,
        "**/.DS_Store": true,
        "**/.mypy_cache": true,
        "**/.pytest_cache": true,
        "**/__pycache__": true,
    },
    "python.pythonPath": ".tox/py38/bin/python",
    "python.formatting.provider": "black",
    "python.languageServer": "Pylance",
}

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@7a8fb8b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   88.52%           
=========================================
  Files             ?        6           
  Lines             ?      122           
  Branches          ?        0           
=========================================
  Hits              ?      108           
  Misses            ?       14           
  Partials          ?        0           
Flag Coverage Δ
pytests 88.52% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8fb8b...d2d1b71. Read the comment docs.

@ltalirz ltalirz merged commit eab1797 into master Jun 2, 2021
@sphuber sphuber deleted the improve-repo branch November 10, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants