-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 MAINTAIN: Improve repo format #9
Conversation
chrisjsewell
commented
Jun 1, 2021
- add build-system
- update pre-commit
- move from yapf -> black
- update manifest
- add isort
- add codecov
- add testing for multiple python versions
- add mypy configuration
- add tox configuration
- add build-system - update pre-commit - move from yapf -> black - update manifest - add isort - add codecov - add testing for multiple python versions - add mypy configuration - add tox configuration
few minor mypy failures that I'll fix later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @chrisjsewell ! Looks fine to me, just some comments/questions
I hope @NinadBhat's work so far has not overlapped too much with this (apologies if it did).
In any case, please see this as encouragement to make PRs early ;-)
yep, and happy to explain any of the additions, and also how to use tox which I highly suggest 😄 (and |
Also FYI, this is my {
"editor.rulers": [88],
"files.exclude": {
"**/.git": true,
"**/.svn": true,
"**/.hg": true,
"**/CVS": true,
"**/.DS_Store": true,
"**/.mypy_cache": true,
"**/.pytest_cache": true,
"**/__pycache__": true,
},
"python.pythonPath": ".tox/py38/bin/python",
"python.formatting.provider": "black",
"python.languageServer": "Pylance",
} |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage ? 88.52%
=========================================
Files ? 6
Lines ? 122
Branches ? 0
=========================================
Hits ? 108
Misses ? 14
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|