Adding the miniforge installer for conda#14
Open
mikibonacci wants to merge 5 commits intoaiidateam:mainfrom
Open
Adding the miniforge installer for conda#14mikibonacci wants to merge 5 commits intoaiidateam:mainfrom
mikibonacci wants to merge 5 commits intoaiidateam:mainfrom
Conversation
- generate_bash_to_install_conda - CONDA_DEFAULT_PATH the script to install conda is generated in the `create_conda_env` function if `install_conda` is `True`. Moreover, now we can define the `path`: `str` k:v in the `conda` input dictionary. This is needed to define a common path where to install and then find conda.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 87.88% 85.50% -2.39%
==========================================
Files 14 14
Lines 652 676 +24
==========================================
+ Hits 573 578 +5
- Misses 79 98 +19 ☔ View full report in Codecov by Sentry. |
d60b2dc to
a70e9a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This installer is needed to install conda on local/remote computer which does not have it, or only have Anaconda (for license reason, we don't want/cannot to use it). This, in principle, can be particularly useful if we want to automatically setup a python code from the aiidalab-qe app.
I basically added two object to the
utils.pyfile:generate_bash_to_install_condafunctionCONDA_DEFAULT_PATHvariablethe script strig to install conda is generated in the
create_conda_envfunction ifinstall_condaisTrue, and merged to the script used to create the conda env (we put the installer script first, in the sh file):... script = generate_bash_to_create_python_env(name, pip, conda, modules, python_version, variables, shell) conda_path = conda.get("path", CONDA_DEFAULT_PATH) if install_conda: install_conda_script = generate_bash_to_install_conda(shell, destination=conda_path, modules=modules) script = install_conda_script + script ...Moreover, now we can define the
path:strk:v in thecondainput dictionary. This is needed to define a common path where to install and then find conda.Missing: