Skip to content

CI: Fix install-with-conda job #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2025
Merged

CI: Fix install-with-conda job #7103

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a012776
CI: Add Slack notification to install-with-conda-job
danielhollas Nov 17, 2025
d9000cf
test whether slack notification works
danielhollas Nov 17, 2025
4b7c486
Revert "test whether slack notification works"
danielhollas Nov 17, 2025
2711bce
Fix install-with-conda job by removing the broken workaround
danielhollas Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions .github/workflows/test-install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,6 @@ jobs:
with:
channels: conda-forge

# Use mamba because conda is running out of memory
# see https://github.com/conda-incubator/setup-miniconda/issues/274
Copy link
Collaborator Author

@danielhollas danielhollas Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary since conda now uses libmamba solver by default.

- run: |
conda install -n base conda-libmamba-solver
conda config --set solver libmamba

# Temporary workaround: https://github.com/mamba-org/mamba/issues/488
- run: rm /usr/share/miniconda/pkgs/cache/*.json
Copy link
Collaborator Author

@danielhollas danielhollas Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step started failing. I haven't investigated too deeply, but simply removing this seems to work.

Copy link
Contributor

@GeigerJ2 GeigerJ2 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from:
6da1333

Using conda now thus probably makes this unnecessary.


- name: Test installation
id: test_installation
continue-on-error: ${{ matrix.optional }}
Expand All @@ -153,6 +144,18 @@ jobs:
echo "::warning ::Failed conda installation for
Python ${{ matrix.python-version }}."

- name: Slack notification
if: >-
failure() &&
github.event_name != 'pull_request' &&
env.SLACK_WEBHOOK != null
uses: ./.github/actions/slack-notification
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
with:
title: Installation via Conda failed on `aiida-core/main`
message: '`test-install.yml:install-with-conda` GHA workflow for Python ${{ matrix.python-version }} failed.'

tests:

needs: [install-with-pip]
Expand Down Expand Up @@ -214,13 +217,11 @@ jobs:
pytest -n auto --db-backend psql -m 'not nightly' tests/

- name: Slack notification
# Always run this step (otherwise it would be skipped if any of the previous steps fail)
# but only if the `install` or `tests` steps failed.
# Run this step if any of the previous steps fail.
# Don't run on PRs, the failure is clearly visible in GitHub UI.
# Run only when the `secrets.SLACK_WEBHOOK` is available, which is not the case for forks.
if: >-
always() &&
(steps.install.outcome == 'failure' || steps.tests.outcome == 'failure') &&
failure() &&
Copy link
Collaborator Author

@danielhollas danielhollas Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better way to express what we need: run this step iff any of the previous steps failed.

https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#failure

github.event_name != 'pull_request' &&
env.SLACK_WEBHOOK != null
uses: ./.github/actions/slack-notification
Expand Down
Loading