review applied

src/aiida/cmdline/commands/cmd_status.py

@@ -16,12 +16,7 @@
 from aiida.cmdline.commands.cmd_verdi import verdi
 from aiida.cmdline.params import options
 from aiida.cmdline.utils import echo
-from aiida.common.exceptions import (
-    CorruptStorage,
-    IncompatibleExternalDependencies,
-    IncompatibleStorageSchema,
-    UnreachableStorage,
-)
+from aiida.common.exceptions import CorruptStorage, IncompatibleStorageSchema, UnreachableStorage
 from aiida.common.log import override_log_level
 from aiida.common.warnings import warn_deprecation
 
@@ -101,12 +96,6 @@ def verdi_status(print_traceback, no_rmq):
             storage_cls = profile.storage_cls
             storage_head_version = storage_cls.version_head()
             storage_backend = storage_cls(profile)
-
-            if storage_cls.__name__ in ['SqliteZipBackend', 'SqliteDosStorage']:
-                from aiida.storage.sqlite_zip.backend import validate_sqlite_version
-
-                validate_sqlite_version()
-
     except UnreachableStorage as exc:
         message = "Unable to connect to profile's storage."
         print_status(ServiceStatus.DOWN, 'storage', message, exception=exc, print_traceback=print_traceback)
@@ -122,10 +111,6 @@ def verdi_status(print_traceback, no_rmq):
         message = 'Storage is corrupted.'
         print_status(ServiceStatus.DOWN, 'storage', message, exception=exc, print_traceback=print_traceback)
         exit_code = ExitCode.CRITICAL
-    except IncompatibleExternalDependencies as exc:
-        message = "Storage backend version doesn't satisfy the requirements of the installed AiiDA version. "
-        print_status(ServiceStatus.DOWN, 'storage', message, exception=exc)
-        exit_code = ExitCode.CRITICAL
     except Exception as exc:
         message = "Unable to instatiate profile's storage."
         print_status(ServiceStatus.ERROR, 'storage', message, exception=exc, print_traceback=print_traceback)

src/aiida/storage/sqlite_dos/backend.py

@@ -244,6 +244,10 @@ def initialise(cls, profile: Profile, reset: bool = False) -> bool:
 
         return super().initialise(profile, reset)
 
+    def __init__(self, profile: Profile) -> None:
+        validate_sqlite_version()
+        super().__init__(profile)
+
     def __str__(self) -> str:
         state = 'closed' if self.is_closed else 'open'
         return f'SqliteDosStorage[{self.filepath_root}]: {state},'

src/aiida/storage/sqlite_zip/backend.py

@@ -104,7 +104,6 @@ def version_head(cls) -> str:
     def create_profile(filepath: str | Path, options: dict | None = None) -> Profile:
         """Create a new profile instance for this backend, from the path to the zip file."""
         profile_name = Path(filepath).name
-        validate_sqlite_version()
         return Profile(
             profile_name,
             {
@@ -185,6 +184,7 @@ def migrate(cls, profile: Profile):
     def __init__(self, profile: Profile):
         from .migrator import validate_storage
 
+        validate_sqlite_version()
         super().__init__(profile)
         self._path = Path(profile.storage_config['filepath'])
         validate_storage(self._path)

tests/cmdline/commands/test_profile.py

@@ -167,7 +167,7 @@ def test_setup_with_validating_sqlite_version(
     config_psql_dos, run_cli_command, isolated_config, tmp_path, entry_point, monkeypatch
 ):
     """Test the ``verdi profile setup`` command.
-    Same as `test_setup`, here we check the fucntionality to check sqlite versions, before setting up profiles.
+    Same as `test_setup`, here we check the functionality to check sqlite versions, before setting up profiles.
     Note that this test should be run before the `test_delete_storage` test.
     """
 

tests/storage/sqlite_zip/test_backend.py

@@ -1,7 +1,6 @@
 """Tests for :mod:`aiida.storage.sqlite_zip.backend`."""
 
 import pathlib
-from unittest.mock import MagicMock
 
 import pytest
 from aiida.common.exceptions import IncompatibleExternalDependencies
@@ -81,17 +80,3 @@ def test_validate_sqlite_version(monkeypatch):
     monkeypatch.setattr('sqlite3.sqlite_version', '100.0.0')
     monkeypatch.setattr('aiida.storage.sqlite_zip.backend.SUPPORTED_VERSION', '0.0.0')
     validate_sqlite_version()
-
-
-def test_initialise_version_check(tmp_path, monkeypatch):
-    """Test :meth:`aiida.storage.sqlite_zip.backend.SqliteZipBackend.create_profile`
-    only if calls on validate_sqlite_version."""
-
-    filepath_archive = tmp_path / 'archive.zip'
-
-    mock_ = MagicMock()
-    monkeypatch.setattr('aiida.storage.sqlite_zip.backend.validate_sqlite_version', mock_)
-    profile = SqliteZipBackend.create_profile(filepath_archive)
-    assert mock_.call_count == 1
-    SqliteZipBackend.initialise(profile)
-    assert mock_.call_count == 2