Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test_leak_ssh_calcjob as nightly #6521

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

danielhollas
Copy link
Collaborator

This is by far the slowest test in the test suite (takes roughly 10% of overall time!). Perhaps it could be moved to nightly tests?

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.79%. Comparing base (ef60b66) to head (314bb96).
Report is 116 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6521      +/-   ##
==========================================
+ Coverage   77.51%   77.79%   +0.29%     
==========================================
  Files         560      562       +2     
  Lines       41444    41858     +414     
==========================================
+ Hits        32120    32560     +440     
+ Misses       9324     9298      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas marked this pull request as ready for review July 5, 2024 23:50
@danielhollas danielhollas requested a review from sphuber July 5, 2024 23:50
@sphuber sphuber merged commit a5da4ed into aiidateam:main Jul 10, 2024
10 checks passed
@danielhollas danielhollas deleted the move-to-nightly branch July 10, 2024 09:35
mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
It is a very slow test and is unlikely to be affected by typical
changes to the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants