Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Do not install aiida-core in editable mode #6369

Closed

Conversation

danielhollas
Copy link
Collaborator

Follow up from discussion in #6363
Let's see if this works, I don't see why it shouldn't...

@danielhollas
Copy link
Collaborator Author

Huh, looks like this fails for the pre-commit run, interesting... cc @sphuber

@sphuber
Copy link
Contributor

sphuber commented Apr 23, 2024

Huh, looks like this fails for the pre-commit run, interesting... cc @sphuber

Seems this may be related python/mypy#13392
It is about setuptools though, but it might very well also impact flit. Haven't found the solution yet though. But if it requires other workarounds, we might as well keep the editable install 😅 it is not as though it has a huge drawback

@sphuber
Copy link
Contributor

sphuber commented Apr 23, 2024

So I think we can close this, right @danielhollas ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants