CalcJob: Fix MPI behavior if withmpi option default is True
#6218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation states that if neither: * the `Code` input (through the `withmpi` attribute) * the `CalcJob` implementation (through `CodeInfo.withpi') * nor the `metadata.options.withmpi` input explicitly defines a boolean value, then the implementation falls back on the _default_ of the `metadata.options.withmpi` input port. However, the code was actually ignoring this and always falling back to `False`. This is now corrected, with `False` still as ultimate fallback value in case a default for `metadata.options.withmpi` is not defined at all.
sphuber
force-pushed
the
fix/calcjob-withmpi-option-default
branch
from
8b7d66b to
2dfabf5
Compare
sphuber
added a commit
that referenced
this pull request
Jan 16, 2024
The documentation states that if neither: * the `Code` input (through the `withmpi` attribute) * the `CalcJob` implementation (through `CodeInfo.withpi') * nor the `metadata.options.withmpi` input explicitly defines a boolean value, then the implementation falls back on the _default_ of the `metadata.options.withmpi` input port. However, the code was actually ignoring this and always falling back to `False`. This is now corrected, with `False` still as ultimate fallback value in case a default for `metadata.options.withmpi` is not defined at all. Cherry-pick: 8473750
sphuber
added a commit
that referenced
this pull request
Jan 17, 2024
The documentation states that if neither: * the `Code` input (through the `withmpi` attribute) * the `CalcJob` implementation (through `CodeInfo.withpi') * nor the `metadata.options.withmpi` input explicitly defines a boolean value, then the implementation falls back on the _default_ of the `metadata.options.withmpi` input port. However, the code was actually ignoring this and always falling back to `False`. This is now corrected, with `False` still as ultimate fallback value in case a default for `metadata.options.withmpi` is not defined at all. Cherry-pick: 8473750
unkcpz
added a commit
to aiidalab/aiidalab-docker-stack
that referenced
this pull request
Jan 22, 2024
aiida-core 2.4.3 include the fix aiidateam/aiida-core#6218 for correctly setup the mpi option of code.
unkcpz
added a commit
to aiidalab/aiidalab-docker-stack
that referenced
this pull request
Jan 23, 2024
aiida-core 2.4.3 include the fix aiidateam/aiida-core#6218 for correctly setup the mpi option of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that if neither:
Codeinput (through thewithmpiattribute)CalcJobimplementation (through `CodeInfo.withpi')metadata.options.withmpiinputexplicitly defines a boolean value, then the implementation falls back on the default of the
metadata.options.withmpiinput port. However, the code was actually ignoring this and always falling back toFalse. This is now corrected, withFalsestill as ultimate fallback value in case a default formetadata.options.withmpiis not defined at all.