CLI: Add short option names for verdi code create
#5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `verdi code create` command replaced `verdi code setup` but unlike its predecessor it only has long option names. To provide short options as well, the `DynamicEntryPointCommandGroup` is extended to support the `short_name` key in an option specification. If specified, the option will provide this short option as well as the automatically determined long option. The `InstalledCode`, `PortableCode` and `ContainerizedCode` are updated to provide short options for those that used to have one in the replaced `verdi code setup` command.
|
Not sure anymore who requested this exactly during the usability feedback meeting of this week. @danielhollas @mkotiuga ? Cannot find Github handle of Louis Beal and Johannes Wasmer |
danielhollas
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
@sphuber it was not me who requested this. FWIW I looked through the changes and they look good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5791
The
verdi code createcommand replacedverdi code setupbut unlike its predecessor it only has long option names. To provide short options as well, theDynamicEntryPointCommandGroupis extended to support theshort_namekey in an option specification. If specified, the option will provide this short option as well as the automatically determined long option.The
InstalledCode,PortableCodeandContainerizedCodeare updated to provide short options for those that used to have one in the replacedverdi code setupcommand.