Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Add pylint_aiida plugin #5182

Merged
merged 5 commits into from
Oct 19, 2021
Merged

🔧 MAINTAIN: Add pylint_aiida plugin #5182

merged 5 commits into from
Oct 19, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Oct 19, 2021

As discussed in #5176 and pylint-dev/pylint#1694,
pylint does not understand the @classproperty decorator,
and so mistakes the method as a function, rather than an attribute of the class.
This commit adds a pylint transform plugin, to remove false-positives.
(see: https://pylint.pycqa.org/en/latest/how_tos/transform_plugins.html)

chrisjsewell and others added 3 commits October 19, 2021 05:10
As discussed in #5176,
pylint does not understand the `@classproperty` decorator,
and so mistakes the method as a function, rather than an attribute of the class.
This commit adds a pylint transform plugin, to remove false-positives.
(see: https://pylint.pycqa.org/en/latest/how_tos/transform_plugins.html)
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #5182 (122c2c6) into develop (8fb1457) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5182      +/-   ##
===========================================
+ Coverage    80.96%   80.96%   +0.01%     
===========================================
  Files          535      535              
  Lines        37185    37188       +3     
===========================================
+ Hits         30104    30107       +3     
  Misses        7081     7081              
Flag Coverage Δ
django 75.75% <100.00%> (+0.01%) ⬆️
sqlalchemy 74.86% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/common/utils.py 77.10% <100.00%> (+0.21%) ⬆️
aiida/transports/transport.py 66.37% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb1457...122c2c6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant