remove ete3 dependency

[ltalirz]

It seems the last use of ete3 was removed in commit
287d138 but the dependency was not
removed.

[ltalirz]

mentioning @aiidateam/dependency-manager

[codecov]

Codecov Report

Merging #4956 (b817d2f) into develop (2f1c1f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4956   +/-   ##
========================================
  Coverage    80.05%   80.05%           
========================================
  Files          515      515           
  Lines        36611    36611           
========================================
  Hits         29305    29305           
  Misses        7306     7306           

Flag	Coverage Δ
django	74.50% <ø> (ø)
sqlalchemy	73.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1c1f8...b817d2f. Read the comment docs.

[sphuber]

How did you discover this? If you haven't done so already, would it make sense to do a quick scan for other unused dependencies?

[ltalirz]

Sure, we can have a look:

pipreqs

$ pip install pipreqs
...
$ pipreqs --print --no-pin aiida | tr '[:upper:]' '[:lower:]' | sort
INFO: Successfully output requirements
aio_pika
aldjemy
alembic
archive_path
ase
beautifulsoup4
bpython
circus
click
click_completion
click_config_file
click_spinner
contextvars
dataclasses
disk_objectstore
docutils
flask
flask_cors
flask_restful
graphviz
ipython
jinja2
jsonschema
kiwipy
matplotlib
mayavi
numpy
pamqp
paramiko
pgsu
pgtest
phonopy
plumpy
psutil
psycopg2
psycopg2_binary
pymatgen
pymysql
pyparsing
pytest
python_dateutil
pytz
pyyaml
pyzmq
reentry
requests
scipy
simplejson
singledispatch
spglib
sphinx
sphinxcontrib_programoutput
sqlalchemy_utils
tabulate
tqdm
tzlocal
upf_to_json
werkzeug
wrapt

This misses the django and sqlalchemy imports; likely because we have folders named django and sqlalchemy in aiida.orm.implementation.

I've checked the rest from the setup.json against this list and could not find any other unused package.

conda_forge_tick

You may have noticed that the conda-forge bot does exactly this analysis (see e.g. the "Packages found in the meta.yaml but not found by inspection" here ), which is why I'm quite confident that this was not a problem with any recent AiiDA releases.
I think the commit 287d138 where deprecated functionality was removed is the most likely place for overlooking something like this.

The bot is using this bit of code.
I haven't installed & run it myself - you're welcome to do so if you like. Otherwise we'll know after the next release ;-)

[sphuber]

Thanks @ltalirz