Templatereplacer: fix files input namespace + add tests #4348
Conversation
ramirezfranciscof
force-pushed
the
hotfix_temprep
branch
from
11c0f33 to
50f3f0c
Compare
|
@ramirezfranciscof I think you may have used an incorrect branch because this seems to include two unrelated commits. |
ramirezfranciscof
force-pushed
the
hotfix_temprep
branch
from
50f3f0c to
aa32928
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4348 +/- ##
===========================================
+ Coverage 79.15% 79.28% +0.14%
===========================================
Files 468 468
Lines 34620 34616 -4
===========================================
+ Hits 27400 27443 +43
+ Misses 7220 7173 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ramirezfranciscof
force-pushed
the
hotfix_temprep
branch
from
aa32928 to
3c618ad
Compare
|
@sphuber There, I fixed that, rebased and all test pass. Thanks for the heads up, I promise I will eventually make a good PR from the first push (⌒_⌒;) |
ramirezfranciscof
force-pushed
the
hotfix_temprep
branch
from
edcdc14 to
dc19c50
Compare
|
Sorry @ramirezfranciscof that should have been |
The `files` namespace is supposed to accept any `SinglefileData` or `RemoteData`, but it was not marked dynamic explicitly. In that case, only explicitly defined ports are excepted, which is not what is intended here.
sphuber
force-pushed
the
hotfix_temprep
branch
from
dc19c50 to
78b73dc
Compare
|
Ah, no problem, I didn't notice either! For me its ready to merge. |
The
filesinput namespace of theTemplatereplacerCalculationwas not dynamic (so it was basically an unusable namespace with no inputs in it). This is a quick fix for that. Additionally, I have added a test for all of its basic functionalities and a test specifically for said namespace.