Ensure KpointsData.reciprocal_cell() works again
#2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
reviewed
Apr 18, 2019
This fixes aiidateam#2749 The `reciprocal_cell` is now a property instead of being an attribute that is attached by calling a method. Also, a couple of tests have been added, and the module kpoints.py fixed to make prospector happy.
giovannipizzi
force-pushed
the
fix_2749_reciprocal_cell
branch
from
8155b1d to
6b155cf
Compare
sphuber
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2749
The
reciprocal_cellis now a property instead of beingan attribute that is attached by calling a method.
Also, a couple of tests have been added, and the module
kpoints.py fixed to make prospector happy.