Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename node class for inline calculations #2195

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Nov 13, 2018

Fixes #2170

The node class changed from InlineCalculation to CalcFunctionNode.

@sphuber sphuber force-pushed the fix_2170_rename_inline_calculation_nodes branch from dacce46 to 02606d0 Compare November 13, 2018 13:51
@coveralls
Copy link

coveralls commented Nov 13, 2018

Coverage Status

Coverage decreased (-0.02%) to 67.581% when pulling 2917fa4 on sphuber:fix_2170_rename_inline_calculation_nodes into 1d21d9a on aiidateam:provenance_redesign.

Copy link
Contributor

@muhrin muhrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you've done here

The node class changed from `InlineCalculation` to `CalcFunctionNode`.
@sphuber sphuber force-pushed the fix_2170_rename_inline_calculation_nodes branch from 02606d0 to 2917fa4 Compare November 13, 2018 14:22
@sphuber sphuber merged commit 1461883 into aiidateam:provenance_redesign Nov 13, 2018
@sphuber sphuber deleted the fix_2170_rename_inline_calculation_nodes branch November 13, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants