Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from coverage.io to coveralls.io #1969

Merged
merged 4 commits into from
Sep 17, 2018
Merged

Switch from coverage.io to coveralls.io #1969

merged 4 commits into from
Sep 17, 2018

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Sep 17, 2018

Will hopefully fix #1905

  • switch from coverage.io to coveralls.io
  • add various badges to README.rst

@ltalirz
Copy link
Member Author

ltalirz commented Sep 17, 2018

For the badges, see here:
https://github.com/ltalirz/aiida_core/tree/issue_1905_coveralls

giovannipizzi
giovannipizzi approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks!
Will you also do a PR to develop? I'm curious to see how much we improve there.
As a note, the release 0.12 branch was set up with also the Jenkins tests are required, but these will never run on a 0.12 branch. I've removed that requirement and left only travis.

@ltalirz
Copy link
Member Author

ltalirz commented Sep 17, 2018

Will you also do a PR to develop?

This would happen with the next release... or should we do it before?

I'm curious to see how much we improve there.

You mean in terms of coverage? The badges are already pointing towards the develop branch.
I thought this would make it easier to merge, also I don't really know what branch I should point to otherwise (master?)

@giovannipizzi
Copy link
Member

Ok, fine to wait for the merge in develop (let's hope it's not too complex ;-) )

@ltalirz ltalirz merged commit 3d25b0c into aiidateam:release_v0.12.3 Sep 17, 2018
ltalirz added a commit to ltalirz/aiida-core that referenced this pull request Sep 17, 2018
@ltalirz
Switch from coverage.io to coveralls.io (aiidateam#1969)
c5c15b5 
* switch from coverage.io to coveralls.io

* adding badges to README
 * travis
 * coveralls
 * rtd
 * pypi
ltalirz added a commit that referenced this pull request Sep 17, 2018
@ltalirz
Switch from coverage.io to coveralls.io (#1969) (#1970)
edc479a 
* Switch from coverage.io to coveralls.io (#1969)

* switch from coverage.io to coveralls.io

* adding badges to README
 * travis
 * coveralls
 * rtd
 * pypi

* remove leftover yml file
@ltalirz ltalirz deleted the issue_1905_coveralls branch October 21, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannipizzi giovannipizzi giovannipizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltalirz @giovannipizzi