Print stack trace after catching ImportError upon entrypoint.load() #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception handling of the caught ImportError when calling entrypoint.load() in the get_plugin() method caused the original ImportError to be swallowed and just raised the LoadingPluginFailed. We not also print the stack trace of the ImportError so that the user knows why the loading of the plugin failed.
ltalirz
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
Thanks a lot @sphuber , that's very helpful (I checked and it works: it now prints both tracebacks, one for the custom exception and, afterwards, the one for the import error).
For me this would be fine, let's wait perhaps for the feedback from the others.
giovannipizzi
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1019
The exception handling of the caught ImportError when calling
entrypoint.load() in the get_plugin() method caused the original
ImportError to be swallowed and just raised the LoadingPluginFailed.
We now also print the stack trace of the ImportError so that the
user knows why the loading of the plugin failed.