Improve/kinds generation #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting detect_kinds=True as default in the `from_ase` and `from_pymatgen` methods of `StructureData`. Co-authored-by: Miki Bonacci <mikibonacci@hotmail.it> Co-authored-by: Yuhao Jiang <jiangyh@buaa.edu.cn>
Also, finalizing the documentation page 01 (StructureData).
Now the sites are the computed field, so immutable. We can access and change the properties via their list: structure.properties.charges[1] = -1
for the constructor. Also: fixed the `get_defined/supported` properties.
We just borrowed and adapted the Hubbard setter and getter methods in the hubbard_mixing.py file (HubbardSetterMixin and HubbardGetterMixin classes).
- hubbard - supercells/slabs
Switch models
This addresses aiidateam#46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #46