-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure the test coverage #441
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
=========================================
Coverage ? 39.21%
=========================================
Files ? 18
Lines ? 3091
Branches ? 0
=========================================
Hits ? 1212
Misses ? 1879
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
b635773
to
7340ff4
Compare
for more information, see https://pre-commit.ci
5afdfc0
to
079c7bb
Compare
Since the reported coverage is well beyond my original goal of 10-15% (as stated in the issue), I am making this PR ready for the review. |
import pytest | ||
|
||
|
||
@pytest.mark.usefixtures("aiida_profile_clean") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this for these two tests. Even in aiida-core tests this fixture is not used very often. From my experience only when the aiida node stored in DB will break or mess up the logic of other tests.
Nevermind, I see for the second test it requires the database to be empty. This is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yakutovicha thanks for adding more tests! I have minor requests and things are not clear to me.
Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good.
@unkcpz @yakutovicha this is great, thanks! 👏 |
fixes #440