[$35] Support React 16 + 17

[aidenybai]

Describe the feature

Currently Million.js supports React 18. It would be nice to support React 16/17 builds.

Additional information

• Would you be willing to help implement this feature?

[aidenybai]

/bounty $35

[algora-pbc]

💎 $35 bounty created by aidenybai
🙋 If you start working on this, comment /attempt #534 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #534 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to aidenybai/million!

Attempt	Started (GMT+0)	Solution
🟢 @rishi-raj-jain	Aug 16, 2023, 9:21:32 PM	#537

[rishi-raj-jain]

@aidenybai

/attempt #534

this'd just involve supporting it in https://github.com/aidenybai/million/tree/main/packages/react & react-server, right?

Options

• Cancel my attempt

[aidenybai]

Yes

[rishi-raj-jain]

Thanks, on it!

[rishi-raj-jain]

How do I validate if my fixes are correct?

[aidenybai]

@rishi-raj-jain create a new vite project. use react 17 + react-dom 17. check if it works. then try with react 18. if it works on both, you can get the bounty

[rishi-raj-jain]

@aidenybai

On it, thanks for the direction!

[rishi-raj-jain]

vite-million-18.zip

Works fine with v18, breaks with v16 and v17 for react-dom errors.

[rishi-raj-jain]

Ohkay, the only problem is of react-dom/client and shall be using react-dom in react < 18. Working on that.

[shubhamsingh259]

I have started working on that issues. I have steuped vite with react 18 and is also supported in react 16/17. Kindly make sure Is it right? then I can share zip file on that

[shubhamsingh259]

@aidenybai Please guide me Am i right?

[algora-pbc]

💡 @rishi-raj-jain submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

[Timonwa]

Hi @shubhamsingh259. You are right. You are to confirm that Million.js works in your vite app without errors when you use v16, v17 and v18 of React and React DOM. Once that is done, open a PR and claim the bounty.

[shubhamsingh259]

ok thanks

[algora-pbc]

🎉🎈 @rishi-raj-jain has been awarded $35! 🎈🎊

[shubhamsingh259]

I have created vite with react18 project. I have also intsalled million.js in vite+react project.
[https://github.com/shubhamsingh259/react-18.git]

[shubhamsingh259]

Please check this repository and kindly guide me. Am I right?.

[shubhamsingh259]

Congratulations!

…

On Fri, 18 Aug 2023, 10:18 algora-pbc[bot], ***@***.***> wrote: 🎉🎈 @rishi-raj-jain <https://github.com/rishi-raj-jain> has been awarded *$35*! 🎈🎊 — Reply to this email directly, view it on GitHub <#534 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOEEFHMJZGYYI7G6ZCMQ7YDXV3XZ7ANCNFSM6AAAAAA3TDDGFI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[joeyfigaro]

What version was this released in? 2.6.0-beta.0 is not a valid tag on npm it looks like. Neither is 2.6.0.

Disregard–looks like I'm looking for @million/lint

Still not sure which version I should use for React v17 quite yet.

For anyone else stumbling here–see #1070 (comment)