Add local friend profile photo override in nickname editor#1
Draft
aidanwolter3 wants to merge 1 commit intomainfrom
Draft
Add local friend profile photo override in nickname editor#1aidanwolter3 wants to merge 1 commit intomainfrom
aidanwolter3 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
localAvatarUrifield toRecipientExtrasinapp/src/main/protowire/Database.prototo persist a per-recipient local avatar URI.RecipientTable.setLocalAvatarUri(...)inapp/src/main/java/org/thoughtcrime/securesms/database/RecipientTable.ktto update the extras blob with the local URI.localAvatarUri()inRecipient.Extrasand include it in equality/hash logic, and prefer the local avatar when resolvingRecipient.contactPhotoandhasAvatarinapp/src/main/java/org/thoughtcrime/securesms/recipients/Recipient.ktso the UI renders the override when present.app/src/main/java/org/thoughtcrime/securesms/nicknames/NicknameActivity.ktto add a document picker flow (usingActivityResultContracts.OpenDocument) that persists read permission and triggersNicknameViewModel.onLocalAvatarChanged(...)on selection or removal, and addonAvatarClick/onRemoveAvatarClickcallbacks and visible buttons under the avatar preview.NicknameViewModel.onLocalAvatarChanged(...)inapp/src/main/java/org/thoughtcrime/securesms/nicknames/NicknameViewModel.ktto persist the local URI viaSignalDatabase.recipients.setLocalAvatarUri(...)on a background dispatcher.NicknameActivity__change_photoandNicknameActivity__remove_photoinapp/src/main/res/values/strings.xml.Testing
./gradlew :app:compileDebugKotlin -x lint -x test, but the build could not run in this environment becauseJAVA_HOME/javais not available, so no automated build/test run completed.Codex Task