feat(component): assignment methods (python) #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SprGrf
force-pushed
the
feat/assignment-methods-python
branch
from
4843a39 to
b0681e2
Compare
domire8
reviewed
Jan 30, 2026
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
domire8
reviewed
Feb 4, 2026
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
SprGrf
commented
Feb 4, 2026
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
domire8
reviewed
Feb 5, 2026
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
domire8
reviewed
Feb 5, 2026
Member
domire8
left a comment
domire8
left a comment
There was a problem hiding this comment.
Just some formatting and one test case that should probably not be expected to throw but otherwise, it looks good!
| """ | ||
| parsed_name = parse_topic_name(name) | ||
| if not parsed_name: | ||
| self.get_logger().error((f"The parsed name for assignment '{name}' is empty. Provide a " |
Member
There was a problem hiding this comment.
This and line 363 look incorrectly formatted
Author
There was a problem hiding this comment.
Fixed these two, but fyi Ruff makes extensive changes to the whole thing, so it should probably be done another time.
Member
There was a problem hiding this comment.
Yes good point, that is because the vscode settings use pylint and autopep and not ruff.. legacy
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/test/python/test_component_interface.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
domire8
approved these changes
Feb 5, 2026
Author
|
Ready to merge, pending a review from @eeberhard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing assignment methods for python components.
Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging: