-
Notifications
You must be signed in to change notification settings - Fork 1
feat(controllers): allow control type change after construction #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SprGrf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Out of curiosity, in which cases do you see a need for this? And why constraint it after configuring?
|
If you check how For the use case, it is mostly the trajectory controllers, which on construction don't know yet which command interfaces they claim, could be velocity or position or even effort. Hence we can decide between contruction and configuring what we want. |
bpapaspyros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise all good for me (I haven't tested, but will do so next week). Wouldn't this be breaking though?
If tested good for me pending the changlog change
bpapaspyros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for me, I've tested quite a bit at this point with no issues or additional requests
Description
This PR adds the option in the
RobotControllerInterfaceto set the joint control type after construction. Once the control type is set on configure however, this is not possible anymore.Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: