feat(controllers): expose parameters from base class #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The controller base class from ROS has two parameters
update_rateandis_async. https://github.com/ros-controls/ros2_control/blob/aefbad38e4371aff499c39f53c8b296a557142cd/controller_interface/src/controller_interface_base.cpp#L37Because of how our add/set parameter logic works, it is currently not possible to set those parameters on the node because the modulo base class doesn't know about them. By adding them to the internal parameter map, it becomes possible to set them (and not fail validation). For the
is_asyncthis is all good.For the
update_rateit is slightly more annoying because we usually use the namerateand typedoublefor this. Keeping in mind that I marked both parameters internal, do you want me to investigate further how we could handle this? It would most likely be yet another parameter that we can then map toupdate_ratebut it's not sure this is a clean and smooth solution.Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: