fix(controllers): reset previous joint commands #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
force-pushed
the
fix/deactivate-controllers
branch
from
cf3718f to
32ee883
Compare
Member
Author
|
Confirmed on the robot that this fixes the parent issue |
eeberhard
changed the title
eeberhard
approved these changes
Jun 6, 2025
bpapaspyros
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue raised by @SprGrf. Upon reactivation, controllers have the previous commands buffered for command rate limiting, so we need to reset those in order to avoid unexpected and probably undesired movements upon reactivation.
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: