feat(components): verify return value of callbacks #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpapaspyros
reviewed
Apr 23, 2025
source/modulo_components/modulo_components/lifecycle_component.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/lifecycle_component.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/lifecycle_component.py
Outdated
Show resolved
Hide resolved
bpapaspyros
previously approved these changes
Apr 24, 2025
eeberhard
reviewed
Apr 24, 2025
Member
eeberhard
left a comment
eeberhard
left a comment
There was a problem hiding this comment.
Looks good, only comments on language and wording
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/lifecycle_component.py
Outdated
Show resolved
Hide resolved
|
Looks good to me |
bpapaspyros
approved these changes
Apr 24, 2025
eeberhard
approved these changes
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the component interfaces in Python in a way that there is a check for the return values of callbacks that are expected to be overridden. This allows better logging for the case where a user might forget to return a bool. Also, to close #205, I catch attribute errors on
validate_parameterand log an error to help the user debug the component.Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging: