feat(core): add joint positions broadcaster and listener (cpp) #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpapaspyros
approved these changes
Feb 20, 2025
bpapaspyros
left a comment
bpapaspyros
left a comment
There was a problem hiding this comment.
small nit/question, otherwise looks good to me
source/modulo_core/include/modulo_core/JointPositionsBroadcaster.hpp
Outdated
Show resolved
Hide resolved
domire8
force-pushed
the
dev/joint-positions
branch
from
f723af6 to
966b2eb
Compare
domire8
changed the title
domire8
commented
Mar 11, 2025
domire8
force-pushed
the
dev/joint-positions
branch
from
966b2eb to
e14c5e5
Compare
domire8
commented
Mar 11, 2025
source/modulo_core/include/modulo_core/JointPositionsListener.hpp
Outdated
Show resolved
Hide resolved
domire8
force-pushed
the
dev/joint-positions
branch
from
e14c5e5 to
ac08d39
Compare
eeberhard
approved these changes
Mar 24, 2025
source/modulo_core/include/modulo_core/JointPositionsBroadcaster.hpp
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by adding the two classes with required interfaces
Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging: