Skip to content

fix(components): remove incorrect log line #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domire8 merged 2 commits into from
Nov 13, 2024
Merged

fix(components): remove incorrect log line #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d56f3e1
fix(components): remove incorrect log line
domire8 Nov 13, 2024
247a635
docs: changelog
domire8 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ Release Versions:
- [2.1.1](#211)
- [2.1.0](#210)

## Upcoming changes

- fix(components): remove incorrect log line (#166)

## 5.0.2

### November 11th, 2024
Expand Down
3 changes: 1 addition & 2 deletions source/modulo_components/modulo_components/lifecycle_component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,9 @@ def __configure_outputs(self) -> bool:
"""
success = True
for signal_name, output_dict in self._ComponentInterface__outputs.items():
self.get_logger().error(f"{signal_name}, {output_dict}")
try:
topic_name = self.get_parameter_value(signal_name + "_topic")
self.get_logger().error(f"Configuring output '{signal_name}' with topic name '{topic_name}'.")
self.get_logger().debug(f"Configuring output '{signal_name}' with topic name '{topic_name}'.")
publisher = self.create_lifecycle_publisher(msg_type=output_dict["message_type"], topic=topic_name,
qos_profile=self.get_qos())
self._ComponentInterface__set_output_publisher(signal_name, publisher)
Expand Down