feat(components): only publish predicates on value change #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpapaspyros
approved these changes
Jun 27, 2024
domire8
force-pushed
the
feat/publish-pred-on-change
branch
2 times, most recently
from
c14a872 to
270836d
Compare
eeberhard
reviewed
Jul 3, 2024
Comment on lines
314
to
321
| TYPED_TEST(ComponentInterfaceTest, AddTrigger) { | ||
| EXPECT_NO_THROW(this->component_->add_trigger("trigger")); | ||
| ASSERT_FALSE(this->component_->triggers_.find("trigger") == this->component_->triggers_.end()); | ||
| EXPECT_FALSE(this->component_->triggers_.at("trigger")); | ||
| EXPECT_FALSE(this->component_->get_predicate("trigger")); | ||
| ASSERT_FALSE( | ||
| std::find(this->component_->triggers_.cbegin(), this->component_->triggers_.cend(), "trigger") | ||
| == this->component_->triggers_.cend()); | ||
| EXPECT_NO_THROW(this->component_->trigger("trigger")); | ||
| // When reading, the trigger will be true only once | ||
| this->component_->triggers_.at("trigger") = true; | ||
| EXPECT_TRUE(this->component_->triggers_.at("trigger")); | ||
| EXPECT_TRUE(this->component_->get_predicate("trigger")); | ||
| // After the predicate function was evaluated once, the trigger is back to false | ||
| EXPECT_FALSE(this->component_->triggers_.at("trigger")); | ||
| EXPECT_FALSE(this->component_->get_predicate("trigger")); | ||
| } |
Member
There was a problem hiding this comment.
I can't see how the triggering still works. Triggers are never added to the actual predicates_ map, are just published as true on trigger(), but I don't see where or how it would be published as false after being triggered. We normally waiting a step to put the trigger back down to false, but maybe you can just try
publish_predicate(trigger_name, true);
publish_predicate(trigger_name, false);
Member
Author
There was a problem hiding this comment.
You are right, I did make this too easy. See my most recent commit. I believe that with
this->set_predicate(trigger_name, true);
this->predicates_.at(trigger_name).set_predicate([]() { return false; });
It will work because the first line changes the predicate value and fires it immediately and then the second step changes the internal predicate value back to false again such that the next time we check all predicate values, it is a falling edge.
domire8
force-pushed
the
feat/publish-pred-on-change
branch
from
270836d to
9b9ba32
Compare
Co-authored-by: Enrico Eberhard <32450951+eeberhard@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by implementing option 3 of the parent issue. Review by commit (there was an intermediate commit just for formatting).
Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging: