fix(modulo-controllers): correctly handle nullptr #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read and understood the Contributor License Agreement and hereby sign it |
Author
|
recheck |
eeberhard
previously approved these changes
Jun 13, 2024
domire8
previously approved these changes
Jun 14, 2024
Member
domire8
left a comment
domire8
left a comment
There was a problem hiding this comment.
Very nice, let's test with a corresponding branch on modulo controllers, then we release it
domire8
changed the title
domire8
approved these changes
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original intention for this branch/PR was to investigate seg faults that would occur when running apps. Along with some issues in the way I was packaging (unrelated to this PR, but related to the seg faults I was seeing), we found a small issue in the way a failed dynamic_pointer_cast would be handled (i.e., it doesn't throw an exception, but returns nullptr).
There also seems to be some sort of issue where we get an EncodedState exception that is followed by a segmentation fault. I can't quite see a reason. We moved the second dereference of the message from
readFromNonRTto potentially prevent this issue (in the case of some sync problem between first and second dereference). Despite this not being very likely, and also not being fully safe, it doesn't hurt to do this in one line.This PR solves the issue by correctly handling a failed dynamic_pointer_cast.
Review guidelines
Estimated Time of Review: 3 minutes
Checklist before merging: