Skip to content

fix(modulo-components): add missing space in log message #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domire8 merged 2 commits into from
Jun 5, 2024
Merged

fix(modulo-components): add missing space in log message #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e15be
fix(modulo-components): add missing space in log message
domire8 Jun 5, 2024
ef83f61
docs: changelog
domire8 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Release Versions:
## Upcoming changes

- fix(modulo-controllers): improve log message (#110)
- fix(modulo-components): add missing space in log message (#113)

## 4.2.1

Expand Down
2 changes: 1 addition & 1 deletion source/modulo_components/src/Component.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ void Component::step() {
this->publish_outputs();
this->publish_predicates();
} catch (const std::exception& ex) {
RCLCPP_ERROR_STREAM(this->get_logger(), "Failed to execute step function:" << ex.what());
RCLCPP_ERROR_STREAM(this->get_logger(), "Failed to execute step function: " << ex.what());
this->raise_error();
}
}
Expand Down
2 changes: 1 addition & 1 deletion source/modulo_components/src/LifecycleComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void LifecycleComponent::step() {
}
this->publish_predicates();
} catch (const std::exception& ex) {
RCLCPP_ERROR_STREAM(this->get_logger(), "Failed to execute step function:" << ex.what());
RCLCPP_ERROR_STREAM(this->get_logger(), "Failed to execute step function: " << ex.what());
// TODO handle error in lifecycle component
// this->raise_error();
}
Expand Down