fix(components): keep parameter values in sync with ros #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
force-pushed
the
fix/parameter-set-vali
branch
from
40502a3 to
e18b938
Compare
eeberhard
reviewed
Jun 10, 2024
Member
eeberhard
left a comment
eeberhard
left a comment
There was a problem hiding this comment.
Looking very promising in general!
source/modulo_components/include/modulo_components/ComponentInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_components/test/cpp/test_component_interface_empty_parameters.cpp
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
domire8
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the parent issue by adding a
pre_set_parameters_callbackto the component interfaces. Because the parametres in that feedback are mutable, we can basically run the whole validation in this callback, and just forward the result to theon_set_parameters_callback.It required some other changes that are rather hard to describe because of the somewhat complex call sequence in ROS but I'm happy to discuss any open points.
If you like it, I have to do the same in the modulo controllers.
Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging: