Skip to content

fix(modulo-controllers): improve log message #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domire8 merged 2 commits into from
May 31, 2024
Merged

fix(modulo-controllers): improve log message #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427f8e7
fix(modulo-controllers): improve log message
domire8 May 31, 2024
1231f25
docs: changelog
domire8 May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Release Versions:
- [2.1.1](#211)
- [2.1.0](#210)

## Upcoming changes

- fix(modulo-controllers): improve log message (#110)

## 4.2.1

### May 29, 2024
Expand Down
8 changes: 4 additions & 4 deletions source/modulo_controllers/src/ControllerInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,14 +659,14 @@ std::string ControllerInterface::validate_service_name(const std::string& servic
}
if (empty_services_.find(parsed_service_name) != empty_services_.cend()) {
RCLCPP_WARN(
get_node()->get_logger(), "Service with name '%s' already exists as %s service.", parsed_service_name.c_str(),
type.c_str());
get_node()->get_logger(), "Service with name '%s' already exists as empty service.",
parsed_service_name.c_str());
return "";
}
if (string_services_.find(parsed_service_name) != string_services_.cend()) {
RCLCPP_WARN(
get_node()->get_logger(), "Service with name '%s' already exists as %s service.", parsed_service_name.c_str(),
type.c_str());
get_node()->get_logger(), "Service with name '%s' already exists as string service.",
parsed_service_name.c_str());
return "";
}
RCLCPP_DEBUG(get_node()->get_logger(), "Adding %s service '%s'.", type.c_str(), parsed_service_name.c_str());
Expand Down