Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine fine-res budget for new ShiELD #383

Merged
merged 13 commits into from
Jun 5, 2020
Merged

Conversation

nbren12
Copy link
Contributor

@nbren12 nbren12 commented Jun 5, 2020

The new simulation had different physics options and therefore different diagnostics outputs. Relevant changes included:

Changes introduced by this commit:

  • Adjust hardcoded budget terms to accomodate the changes above. The team suggested that I not overgeneralize this code since won't have a new dataset anytime soon.
  • Update test schema to reflect the new training data
  • Add unit and long_name information to the outputs
  • Simplify the variable renaming logic. Previously "_coarse" was automatically stripped from all the names of the diagnostic output, which made it tricky to know infer what variables were available at a particular step of the pipeline. Now most of the renaming is concentrated into one function.
  • Adjust FineResolutionSources to reflect this schema change.

VCMML-310

Closes #347

- Remove _coarse stripping logic. Explicit is better
- Add units and other metadata to output data
- Replace "microphysics" arg with "saturation_adjustment" in
"compute_recoarsened_budget"
@nbren12
Copy link
Contributor Author

nbren12 commented Jun 5, 2020

Thanks @brianhenn for the unit tests of the mapper. It's sooo much easier working with a code base that has some unit test coverage.

Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nbren12 -- this looks great to me. I agree it's nice to keep the variable names directly read in from the diagnostics constant (rather than removing the "_coarse" suffix).

Note this should close #347.

workflows/fine_res_budget/budget/budgets.py Outdated Show resolved Hide resolved
tests/loaders/test__transform.py Outdated Show resolved Hide resolved
tests/loaders/test__transform.py Outdated Show resolved Hide resolved
@nbren12 nbren12 merged commit 4cd497f into master Jun 5, 2020
@nbren12 nbren12 deleted the feature/redefine-budget branch June 5, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in relevant set and meaning of diagnostics with inline vs. regular microphysics
2 participants