Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the management of regression data #186

Open
nbren12 opened this issue Apr 30, 2021 · 0 comments
Open

Simplify the management of regression data #186

nbren12 opened this issue Apr 30, 2021 · 0 comments

Comments

@nbren12
Copy link
Contributor

nbren12 commented Apr 30, 2021

There is fair amount of complexity associated with managing the regression checksum files. This makes the process for updating this process somewhat idiosyncratic and the test code a little complicated. The pytest-regtest plugin can make this much simpler. It provides a fixture regtest that can be used for saving regression data:

def test_reg(regtest):
    print("this should never change", file=regtest)

This will check the printed string against a file named _regtest_outputs.test_reg.out which should then be checked into git. This file can be updated by calling pytest --regtest-reset

See this PR for example: https://github.com/VulcanClimateModeling/fv3gfs-wrapper/pull/272/files

nbren12 pushed a commit that referenced this issue Apr 11, 2022
Switching our fv3config data to requester pays broke the docker build system. We had been discussing already removing the cache from the docker image to reduce the image size. This PR removes the fv3config initial cache from the docker image. As a consequence, data will be downloaded instead at run/test time.

This may increase the amount of data transferred, or it might not.

This PR also refactors the runfile examples to no longer use fv3run, to avoid a bug where fv3run does not appropriately pass on credentials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant