test: make frontend hermetic tests xdist-safe with dynamic ports #4992
+527
−271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add shared per-test port allocation for frontend/serve tests\n- Add gRPC metrics port flag and plumb http_metrics_port to avoid 8788 collisions\n- Update hermetic HTTP/gRPC frontend tests for dynamic ports + readiness\n- Write per-test logs under /tmp to avoid polluting the repo root\n- CI wall time improvement (measured): pre_merge gRPC pair 87.48s -> 25.27s (3.46x); post_merge completion mocker 97.29s -> 30.29s (3.21x) Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
keivenchang
commented
Dec 17, 2025
| default=False, | ||
| help="Start KServe gRPC server.", | ||
| ) | ||
| parser.add_argument( |
Contributor
Author
There was a problem hiding this comment.
Adding a configurable parameter so that parallel running gRPC tests can use different ports without colliding.
| TEST_MODEL = QWEN | ||
|
|
||
|
|
||
| class DynamoFrontendProcess(ManagedProcess): |
Contributor
Author
There was a problem hiding this comment.
Removed; using a common class now.
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class DynamoFrontendProcess(ManagedProcess): |
Contributor
Author
There was a problem hiding this comment.
Removed; using a common class.
|
|
||
| @pytest.mark.e2e | ||
| @pytest.mark.pre_merge | ||
| @pytest.mark.gpu_1 |
Contributor
Author
There was a problem hiding this comment.
This test doesn't use any GPU, so marking it as gpu_0.
| # - tests/frontend/test_vllm.py | ||
| # - tests/frontend/test_completion_mocker_engine.py | ||
| # - tests/frontend/grpc/test_tensor_parameters.py | ||
| # - tests/frontend/grpc/test_tensor_mocker_engine.py |
Contributor
Author
There was a problem hiding this comment.
3 down, many more tests to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Make hermetic frontend tests safe to run under pytest-xdist by allocating per-test ports (frontend + worker system ports) and removing the hardcoded gRPC metrics port collision. This also redirects per-test logs to /tmp to avoid polluting the repo root during parallel runs.
Details:
ServicePorts) and use it across frontend + serve tests--grpc-metrics-portflag to the frontend and plumbhttp_metrics_portthrough Python/Rust so gRPC mode can run in parallel without 8788 conflicts-n auto)/tmpto avoid creating lots of untrackedtest_*directories in the repo rootWhere should the reviewer start?
Related Issues: (use Closes / Fixes / Resolves / Relates to)
Relates to OPS-2568
/coderabbit profile chill