DO NOT swallow the exceptions #279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least you will know why loading the library fails
bfontaine
reviewed
May 15, 2023
| return ctypes.CDLL(lib) | ||
| except OSError as err: | ||
| logging.warning(err) | ||
| pass |
cclauss
reviewed
May 17, 2024
| return ctypes.CDLL(lib) | ||
| except OSError as err: | ||
| logging.warning(err) | ||
| pass |
ahupp
added a commit
that referenced
this pull request
May 26, 2024
Owner
|
Sorry for the delay, I definitely have sympathy for how frustrating it is to debug a swallowed exception. I've rebased this on recent changes and merged as a9e6276. |
ddelange
added a commit
to ddelange/python-magic
that referenced
this pull request
May 26, 2024
…bi3-wheels * 'master' of https://github.com/ahupp/python-magic: log warning on ctypes load error, adapted from ahupp#279 smartos support, adapted from ahupp#132 rename no_json test to avoid duplicate function definitions handle unknown platforms gracefully in loader.py Clean up loader.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least you will know why loading the library fails