Adding a comment fails with `Symbol's function definition is void: filename`

[mvarela]

Hi! When trying to add a comment via org-jira-add-comment, I get the above error.

(defun org-jira-add-comment (issue-id filename comment)
"For ISSUE-ID in FILENAME, add a new COMMENT string to the issue region."
(interactive
 (let* ((issue-id (org-jira-get-from-org 'issue 'id))
        (filename (org-jira-filename))        ;; <<<<<------- This seems to be the offending line
        (comment (read-string (format  "Comment (%s): " issue-id))))
   (list issue-id filename comment)))
(lexical-let ((issue-id issue-id)
              (filename filename))
  (ensure-on-issue-id-with-filename issue-id filename
    (goto-char (point-max))
    (jiralib-add-comment
     issue-id comment
     (cl-function
      (lambda (&key _data &allow-other-keys)
        (ensure-on-issue-id-with-filename issue-id filename
          (org-jira-update-comments-for-current-issue))))))))

When just evaluating (org-jira-filename) in the issue buffer, it seems to return the correct file name, so I'm a bit lost as to what the error may be.
Any help would be appreciated!

[ahungry]

Are you calling org-jira-add-comment with a hotkey, or via evaluation?

Where is the cursor when you call it? (In an org entry body, or in the property drawer area?)

[mvarela]

I'm calling it via smex, haven't decided on using the bindings yet.
The error happens whether I'm on the ticket header, on the properties drawer, or in the body itself.

[ahungry]

Just eyeballing it, I'm wondering if the issue is actually in the lexical-let, where it has (filename filename) - maybe it's incorrectly treating that as a function call (due to filename itself being undefined in some way?)

I'll have to try this out and loop back around - I wonder if anyone else has experienced the issue?

What Emacs are you using?

[ahungry]

Looking into - I was able to reproduce...

[ahungry]

27e69c7 changed how the filename is handled - if I call it manually while on top of an issue (org-jira-filename) I get the ticket key as the name ("AHU-23"), while if I revert the commit, I get the proper file name when it may be a customized file (like "last-years-work.org").

[ahungry]

#268 - related discussion - that covers some of the history and may or may not be related - I'll have to look to see what a suitable fix is.

[ahungry]

Interesting - making a commit message with "Fix: " auto-closed the issue - in any case, I think this should be working now via commit b4cbefc

[mvarela]

I'm running a git build (maybe a couple of months old, native compiled branch, with GTK support). I'll try the latest commit you pointed to, and see if that works out!
Thanks for being so responsive!

[ahungry]

Awesome - try the latest HEAD, I had a few other commits that followed the referenced one

[mvarela]

Yep, that did the trick. Thanks!