Disable all tslint and eslint rules in generated code #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tslint configurations.
mjambon
requested review from
rgrinberg,
Khady,
zindel and
cyberhuman
as code owners
mjambon
added a commit
to semgrep/semgrep-interfaces
that referenced
this pull request
Jan 24, 2023
mjambon
changed the title
"Module.createRequire is not a function" when running eslint.
Khady
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a special comment to disable all warnings and errors that tslint could otherwise report under some configuration.
Note that following all the tslint rules doesn't make sense for generated code. We could however make an effort to stick to most of the recommended rules. This is a task for another day (if anyone cares).
We now run tslint as part of the tests to ensure that no error or warning is produced.
Fixes #327
PR checklist
CHANGES.mdis up-to-date