-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete tests for kubectx #113
Conversation
cc: @doodlesbykumbi your review is appreciated! |
test/kubectx.bats
Outdated
} | ||
|
||
@test "delete non existent context" { | ||
use_config config2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably can use config1 here (try using simple ones when you can)
Please ping me when it's ready to review again. I'm super happy of this work! |
github did not detect all changes, but I think it is ok for the next review. Thanks :) |
ah btw don't forget to set your git author.name/email fields correctly so they show up on github associated to your profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one little nit and almost ready to go 🙏
I rebased my commits so they are attached to my github account now. |
Thanks a lot! This brings us to 19 tests for kubectx alone. |
Hey y'all. Sorry, quite late to the game was thoroughly AFK over the new year break. This is amazing work. Well done @feloy! |
Hmm looks like we have 24 tests alone in this file. but the test output showed 19 for some reason (both kubectx and kubens) https://travis-ci.org/ahmetb/kubectx/builds/474502614?utm_source=github_status&utm_medium=notification
|
perhaps we can split the invocations ?
|
@ahmetb i'm confused there's only 19 instances of |
my bad. I was ctrl+f ing the diff view. |
No description provided.