Skip to content

Conversation

@pazka
Copy link

@pazka pazka commented Dec 14, 2020

feat : possibility to change the newline split for different file format
debug : couldn't generate a new file from basic json data

Feat description :
When using a file format that does newline as '\r\n' and not '\n', the "splitRecords" function wasn't able to split correctly the records. SO I added a possibility to set externally the newline split string.

Debug description :
the "Options" property in the record object wasn't included in the parse to RecordObject, which then wasn't taken into account upon generating new db.local file.
Also, the generated custom Object wasn't the same as the documentation, because of lowercase keys and the "Option" property

This PR close the Issue #1

debug : couldn't generate a new file from basic json data

Feat description :
When using a file format that does newline as '\r\n' and not '\n', the "splitRecords" function wasn't able to split correctly the records. SO I added a possibility to set externally the newline split string.

Debug description :
the "Options" property in the record object wasn't included in the parse to RecordObject, which then wasn't taken into account upon generating new db.local file.
Also, the generated custom Object wasn't the same as the documentation, because of lowercase keys and the "Option" property
@ahmadyazdanii
Copy link
Owner

hi, your change don't include previous version and generate conflict in parse older config file !!

@pazka
Copy link
Author

pazka commented Jan 4, 2021

Do you have an example set that I can run my changes against, to check the errors in the parsing of those other config files ?

Alternatively, I can give you the file I was using that wasn't working with the current version

@ahmadyazdanii
Copy link
Owner

Yes please send a file that can make errors in the current version. You can also test your new codes with examples in readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants