Skip to content

Conversation

sadiqhabib
Copy link
Contributor

Add view latest version support from package.json file and script for quick testing

Copy link
Owner

@ahmadassaf ahmadassaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition ! thanks

@ahmadassaf ahmadassaf merged commit fd95ae2 into ahmadassaf:master Apr 3, 2017
@sadiqhabib
Copy link
Contributor Author

Your are welcome you can also close now #5 as well

@ahmadassaf
Copy link
Owner

already did :) thanks

@sadiqhabib
Copy link
Contributor Author

I have one problem in cmd gitignore option is not working .

@ahmadassaf
Copy link
Owner

can you elaborate more ? what argument are you passing and what are the contents of your gitignore file .. and what is happening ?

@sadiqhabib
Copy link
Contributor Author

sadiqhabib commented Apr 3, 2017

See my test:clean script command or run npm run test:clean in cmd it is also looking inside node_modules as well

@ahmadassaf
Copy link
Owner

have you tried the -g instead ?

@ahmadassaf
Copy link
Owner

sorry i cannot test it now as i am not on a laptop .. browsing from phone ATM

@sadiqhabib
Copy link
Contributor Author

Yeah both are making same problem. and i am getting all messages even from ignored dirs too

@ahmadassaf
Copy link
Owner

am not really sure whats happening but i believe its about the path to the .gitignore and maybe how you are calling the command. What i think is happening is that it tries to find the path relative to bin/path .. cannot confirm until i test

@sadiqhabib
Copy link
Contributor Author

sadiqhabib commented Apr 3, 2017

I tested even global installed version still getting notes from ignored files with this command notes -g .gitignore no path just navigate to project dir and run this but still it is making problem

@ahmadassaf
Copy link
Owner

have you tried doing notes -g ./.gitignore

@sadiqhabib
Copy link
Contributor Author

Yes same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants